Bump checkstyle from 8.18 to 8.29

[dependabot]

Bumps checkstyle from 8.18 to 8.29.

Release notes

Sourced from checkstyle's releases.

checkstyle-8.29

https://checkstyle.org/releasenotes.html#Release_8.29

checkstyle-8.28

https://checkstyle.org/releasenotes.html#Release_8.28

checkstyle-8.27

https://checkstyle.org/releasenotes.html#Release_8.27

checkstyle-8.26

https://checkstyle.org/releasenotes.html#Release_8.26

checkstyle-8.25

https://checkstyle.org/releasenotes.html#Release_8.25

checkstyle-8.24

https://checkstyle.org/releasenotes.html#Release_8.24

checkstyle-8.23

https://checkstyle.org/releasenotes.html#Release_8.23

checkstyle-8.22

https://checkstyle.org/releasenotes.html#Release_8.22

checkstyle-8.21

https://checkstyle.org/releasenotes.html#Release_8.21

checkstyle-8.20

https://checkstyle.org/releasenotes.html#Release_8.20

checkstyle-8.19

https://checkstyle.org/releasenotes.html#Release_8.19

Commits

• 8933d03 [maven-release-plugin] prepare release checkstyle-8.29
• bd45909 Issue #7487: refactor code to use DetailAST.hasChildren()
• 317e51f Issue #7487: add method hasChildren() to DetailAST
• 89b4dcd Issue #3238: Java 8 Grammar: annotations on arrays and varargs
• 252cd89 dependency: bump junit-pioneer from 0.5.1 to 0.5.2
• 2ee2615 dependency: bump junit.version from 5.5.2 to 5.6.0
• 4ed7cb8 minor: add space before xml comment end '-->' to ease reading and make links ...
• c46a16d Issue #7468: disable 'external-parameter-entities' feature by default
• dfed794 minor: add missing test case to SuperCloneCheckTest
• 24e7bdf dependency: bump antlr4.version from 4.7.2 to 4.8-1
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

[tobywf]

(checkstyle) on project aws-cloudformation-rpdk-java-plugin: Failed during checkstyle configuration: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard.

[tobywf]

Seems to be broken by: checkstyle/checkstyle#2116

[tobywf]

It gets more complicated, maven-checkstyle-plugin is stuck at 3.1.0 (last release was from 2019-05-12), which uses checkstyle 8.19 by default. I have followed the guide to update checkstyle at runtime, in fact we already did this, but it still seems incompatible.

My mistake, it's actually com.github.aws.aws-sdk-java-v2:build-tools causing the issue. I'll tie this to the AWS SDK version we use, so it will automatically get updated when somebody updated that.

[tobywf]

Build-tools is still stuck on 8.18: aws/aws-sdk-java-v2#1626

More drama, separateLineBetweenGroups seems to be broken in CheckStyle 8.29 (backwards-incompatible change at least not pointed out in the changelog): checkstyle/checkstyle#7537

[rjlohan]

The CVE indicates we're probably not really at risk here;

This vulnerability probably doesn't impact Maven/Gradle users as, in most cases, these builds are processing files that are trusted, or pre-vetted by a pull request reviewer before being run on internal CI infrastructure.

We should fix when we can, but not urgently if other things are going to break.

[tobywf]

Spotless' importOrder automatically inserts line breaks, ignoring the Eclipse formatter. Solution was to run it before the formatter

[tobywf]

The CVE indicates we're probably not really at risk here;

Agreed, but be good to upgrade. Although, I think CheckStyle is an issue, with the number of breaking changes even in minor version numbers. Maybe an indicator we should dump it?

Anyway, I'll push what I have so far.

[rjlohan]

Although, I think CheckStyle is an issue, with the number of breaking changes even in minor version numbers. Maybe an indicator we should dump it?

Yeah maybe, though I like that it means I don't have to nitpick styling stuff in PRs...