Skip to content

Conversation

xiwhuang
Copy link
Member

@xiwhuang xiwhuang commented May 7, 2020

What are we changing?

  • Added two proxy methods to extend ResponseInputStream<AwsResponse> and ResponseBytes<AwsResponse>

Why are we changing?

  • A few uncommon AWS APIs like S3::GetObject requires AWS Credentials Provider to authenticate the API requests

What happens if we do not change?

How did we test?

  • Manually tested the changes locally.
  • Associated Unit tests pass.
  • Create/Update/Delete succeed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@wbingli wbingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@xiwhuang xiwhuang merged commit a31e120 into aws-cloudformation:master May 7, 2020
@xiwhuang xiwhuang deleted the add_method branch May 7, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants