Skip to content

Conversation

goughcor
Copy link
Contributor

Description of changes:
Log request name and request id.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@goughcor goughcor changed the title Cloudtrail request Cloudtrail log request id and request name. May 21, 2020
@rjlohan
Copy link
Contributor

rjlohan commented May 21, 2020

I added it to injectCredentialsAndInvoke in the latest commit. What about the other methods? (Ex: injectCredentialsAndInvokeV2InputStream) Does it need to be added there too?

Yeah you'll probably want to wrap all the calls like return requestFunction.apply(wrappedRequest); to get full coverage from this logging.

@goughcor
Copy link
Contributor Author

I added it to injectCredentialsAndInvoke in the latest commit. What about the other methods? (Ex: injectCredentialsAndInvokeV2InputStream) Does it need to be added there too?

Yeah you'll probably want to wrap all the calls like return requestFunction.apply(wrappedRequest); to get full coverage from this logging.

I added logging to the other calls. We should have full coverage now.

@wbingli wbingli requested review from johnttompkins and wbingli June 1, 2020 20:52
@rjlohan rjlohan merged commit 1e499bc into aws-cloudformation:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants