Handle void response in injectCredentialsAndInvoke #338
+42
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammokhov
reviewed
Dec 8, 2020
src/main/java/software/amazon/cloudformation/proxy/AmazonWebServicesClientProxy.java
Show resolved
Hide resolved
ammokhov
reviewed
Dec 9, 2020
src/main/java/software/amazon/cloudformation/proxy/AmazonWebServicesClientProxy.java
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/proxy/AmazonWebServicesClientProxy.java
Show resolved
Hide resolved
johnttompkins
approved these changes
Dec 10, 2020
src/main/java/software/amazon/cloudformation/proxy/AmazonWebServicesClientProxy.java
Show resolved
Hide resolved
src/main/java/software/amazon/cloudformation/proxy/AmazonWebServicesClientProxy.java
Show resolved
Hide resolved
| } | ||
|
|
||
| public <RequestT extends AmazonWebServiceRequest> void injectCredentialsAndInvoke(final RequestT request, | ||
| final Consumer<RequestT> requestFunction) { |
There was a problem hiding this comment.
we should also just make a void function for the v2 proxy as well? if we are tackling the v1 here?
There was a problem hiding this comment.
I think v2 functions are required to return a result and are never void. @ammokhov can you please confirm?
ammokhov
approved these changes
Dec 11, 2020
hex-y
added a commit
to hex-y/aws-cloudformation-resource-providers-rds-proxy
that referenced
this pull request
Feb 24, 2021
cloudformation-cli-java-plugin made a change to overload injectCredentialsAndInvoke, this breaks our unit test. aws-cloudformation/cloudformation-cli-java-plugin#338 Update the pom.xml for the repository url, as http was no longer supported. Updtae the aws-cloudformation-rpdk-java-plugin version to [2.0.0, 3.0.0)
hex-y
added a commit
to aws-cloudformation/aws-cloudformation-resource-providers-rds-proxy
that referenced
this pull request
Feb 24, 2021
…19) * Update the unit test following changes in injectCredentialsAndInvoke cloudformation-cli-java-plugin made a change to overload injectCredentialsAndInvoke, this breaks our unit test. aws-cloudformation/cloudformation-cli-java-plugin#338 Update the pom.xml for the repository url, as http was no longer supported. Update the aws-cloudformation-rpdk-java-plugin version to [2.0.0, 3.0.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#176
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.