-
Notifications
You must be signed in to change notification settings - Fork 48
Add CloudFormation resource type configuration support #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this must be merged befor #369
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz fix coverage
Failing checks are due to unreleased changes in cfn-cli. Validated that they pass locally.
|
Validated type configuration changes manually by running |
...ava/software/amazon/cloudformation/exceptions/CfnInvalidTypeConfigurationExceptionTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the plugin version bump from this PR to maintain clean history
public <ResourceT, CallbackT, | ||
ConfigurationT> void rescheduleAfterMinutes(final String functionArn, | ||
final int minutesFromNow, | ||
final HandlerRequest<ResourceT, CallbackT, ConfigurationT> handlerRequest) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it even used anywhere? @srujithpoondla03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I think there is some cleanup required in this repo for V1 Code(not just this pull request). We did not totally remove the code related to CW events yet.
Issue #, if available:
Description of changes:
Add TypeConfiguration support for Resource Types
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.