Skip to content

Conversation

RedbackThomson
Copy link
Contributor

Issue #, if available: aws-controllers-k8s/community#1637

Description of changes:
Adds service metadata to the metadata.yaml file

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot
Copy link
Collaborator

ack-bot commented Jan 19, 2023

@RedbackThomson: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
acm-recommended-policy-test 7ffd793 link /test acm-recommended-policy-test
acm-kind-e2e 7ffd793 link /test acm-kind-e2e
acm-release-test 7ffd793 link /test acm-release-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@RedbackThomson
Copy link
Contributor Author

I will manually merge this PR once it has been approved, since I'm not ready to add a recommended policy or e2e tests, but the documentation needs to be fixed

@RedbackThomson RedbackThomson linked an issue Jan 19, 2023 that may be closed by this pull request
@ack-bot
Copy link
Collaborator

ack-bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RedbackThomson RedbackThomson merged commit d35a1d8 into aws-controllers-k8s:main Jan 19, 2023
@RedbackThomson RedbackThomson deleted the fix-metadata branch January 19, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix API Reference metadata bugs
3 participants