link ack-runtime with code-generator via go.mod #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though Go code in the code-generator doesn't actually import the ack-runtime library (github.com/aws-controllers-k8s/runtime), the templates contained in the code-generator *do* produce Go code that imports the ack-runtime. So, in order to fake out a Go module dependency between the code-generator and the ack-runtime, I've added a simple test file in pkg/generate/ack/runtime_test.go that effectively couples the ack-runtime library at v0.0.3. When we make changes in the ack-runtime that break backwards compatibility, we can now update the SemVer in the ack-runtime repo and the commits to the code-generator that change the produced Go code that follows the new interfaces in ack-runtime can update the depended-on ack-runtime version in the code-generator repository's go.mod file.
jaypipes
commented
Feb 22, 2021
| @@ -14,5 +15,5 @@ require ( | |||
| github.com/spf13/cobra v1.1.1 | |||
| github.com/stretchr/testify v1.7.0 | |||
| golang.org/x/mod v0.4.1 | |||
| k8s.io/apimachinery v0.20.2 | |||
| k8s.io/apimachinery v0.18.6 | |||
There was a problem hiding this comment.
Note to reviewers: this was necessary in order to avoid this issue: kubernetes/client-go#741
jaypipes
requested review from
a-hilaly,
kumargauravsharma,
RedbackThomson,
surajkota and
vijtrip2
surajkota
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though Go code in the code-generator doesn't actually import the
ack-runtime library (github.com/aws-controllers-k8s/runtime), the
templates contained in the code-generator do produce Go code that
imports the ack-runtime. So, in order to fake out a Go module dependency
between the code-generator and the ack-runtime, I've added a simple test
file in pkg/generate/ack/runtime_test.go that effectively couples the
ack-runtime library at v0.0.3.
When we make changes in the ack-runtime that break backwards
compatibility, we can now update the SemVer in the ack-runtime repo and
the commits to the code-generator that change the produced Go code that
follows the new interfaces in ack-runtime can update the depended-on
ack-runtime version in the code-generator repository's go.mod file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.