Skip to content

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented Aug 21, 2025

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 August 21, 2025 17:15
@ack-prow ack-prow bot added the approved label Aug 21, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
Copy link

ack-prow bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knottnt
Copy link
Contributor Author

knottnt commented Aug 21, 2025

/retest

1 similar comment
@knottnt
Copy link
Contributor Author

knottnt commented Aug 21, 2025

/retest

@knottnt
Copy link
Contributor Author

knottnt commented Aug 21, 2025

/test s3-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Aug 21, 2025

/test eks-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Aug 21, 2025

/test s3-controller-test

2 similar comments
@knottnt
Copy link
Contributor Author

knottnt commented Aug 22, 2025

/test s3-controller-test

@knottnt
Copy link
Contributor Author

knottnt commented Aug 22, 2025

/test s3-controller-test

Copy link

ack-prow bot commented Aug 22, 2025

@knottnt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution 84e8670 link false /test verify-attribution
s3-olm-test 84e8670 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link
Contributor Author

knottnt commented Aug 22, 2025

/test s3-controller-test

@ack-prow ack-prow bot merged commit 1045a5e into aws-controllers-k8s:main Aug 22, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants