Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching an instance using ec2-controller service controller #1196

Closed
5 tasks
brycahta opened this issue Mar 2, 2022 · 4 comments
Closed
5 tasks

Launching an instance using ec2-controller service controller #1196

brycahta opened this issue Mar 2, 2022 · 4 comments
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@brycahta
Copy link
Contributor

brycahta commented Mar 2, 2022

Summary

Users should be able to launch and manage an EC2 Instance using ec2-controller service controller. The solution should be functional, align with the k8s experience, and pragmatic. For example, launching an instance should be possible with a single yaml file not requiring users to build up dependencies/infrastructure on their own.

Context

This is the parent issue to track and implement work related to the ec2 instance resource controller. Feel free to comment on this issue with relevant topics or open an issue in the community repo for further discussion.

Initial Implementation for EC2 Instance resource

  • Create/Delete functionality
  • Possibly override Instance.Status fields depending on return types in CreateOutput shape. runInstances api returns a list of Reservation not Instance
  • Add exception handling
  • Leverage referenced resources feature to launch an Instance using infrastructure created by ACK (i.e. launch an instance using a VPC created by ACK and referenced in instance.yaml)
  • Add update/modify functionalities based on priority
@ack-bot
Copy link
Collaborator

ack-bot commented May 31, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-bot ack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 31, 2022
ack-bot pushed a commit to aws-controllers-k8s/ec2-controller that referenced this issue Jun 2, 2022
Issue #, if available: aws-controllers-k8s/community#1196

Description of changes:
* Instance Controller create/delete functionality with smoke test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@ack-bot
Copy link
Collaborator

ack-bot commented Jun 30, 2022

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-bot ack-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 30, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 30, 2022

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-bot ack-bot closed this as completed Jul 30, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Jul 30, 2022

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants