Skip to content

chore: move updates from create to sdkUpdate #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michaelhtm
Copy link
Member

Description of changes:
Currently, we attempt to make certain update calls in sdkCreate, right
after we populate the resource from createOutput. These calls usually
fail as the Table may still be in Creating status.

Another issue that kept happening was a throttling error during sdkFind
for the DescribeTTL call. With these changes, we will be checking the
Table status and reconciling if needed, and only retrieving TTL when the
table has available status.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently, we attempt to make certain update calls in sdkCreate, right
after we populate the resource from createOutput. These calls usually
fail as the Table may still be in `Creating` status.

Another issue that kept happening was a throttling error during sdkFind
for the DescribeTTL call. With these changes, we will be checking the
Table status and reconciling if needed, and only retrieving TTL when the
table has `available` status.
@ack-prow ack-prow bot requested review from jlbutler and knottnt July 15, 2025 01:44
@ack-prow ack-prow bot added the approved label Jul 15, 2025
@michaelhtm michaelhtm removed the request for review from jlbutler July 15, 2025 01:44
Copy link

ack-prow bot commented Jul 15, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
dynamodb-verify-attribution e9882c6 link false /test dynamodb-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2025
Copy link

ack-prow bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit bcd26e1 into aws-controllers-k8s:main Jul 15, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants