Skip to content

Conversation

sudohikumar
Copy link
Contributor

Issue #, if available:

Description of changes:
Since the bottlerocket versions don't align with EKS Versions, we should ignore the check of comparing nodeversion and eks version. Otherwise, it will result in error similar to version and release version do not match: 1.32 and 1.47

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and michaelhtm October 1, 2025 19:02
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 1, 2025
Copy link

ack-prow bot commented Oct 1, 2025

Hi @sudohikumar. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knottnt
Copy link
Contributor

knottnt commented Oct 1, 2025

Thanks for the PR @sudohikumar

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2025
@sudohikumar
Copy link
Contributor Author

/test eks-verify-attribution

@sudohikumar
Copy link
Contributor Author

Hey @knottnt ,
Not sure how to resolve the failing build here for eks-verify-attribution. Please assist.
Thank you.

Copy link
Contributor

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. Appreciate the contribution!

Copy link

ack-prow bot commented Oct 2, 2025

@sudohikumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
eks-verify-attribution e7910ec link false /test eks-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sudohikumar
Copy link
Contributor Author

Hi @knottnt
I have addressed comments. Can you please re-review?

@knottnt knottnt self-requested a review October 2, 2025 18:58
Copy link
Contributor

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sudohikumar!

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2025
Copy link

ack-prow bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, sudohikumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Oct 2, 2025
@ack-prow ack-prow bot merged commit e38f537 into aws-controllers-k8s:main Oct 2, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants