Skip to content

Conversation

gustavodiaz7722
Copy link

This PR updates controller src and test files to the Ready condition:

  • Run code generation
  • Update test infra commit id
  • Replace ACK.ResourceSyncedReady
  • Replace assert_syncedassert_ready
  • Replace assert_not_syncedassert_not_ready

Generated by helper script.

No manual changes were made to the controller source; all changes were made via automated script.

@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 September 25, 2025 05:37
Copy link

ack-prow bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gustavodiaz7722
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gustavodiaz7722
Copy link
Author

/retest-required

Copy link

ack-prow bot commented Sep 26, 2025

@gustavodiaz7722: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution 4cc1641 link false /test elasticache-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

# assert AF and multi AZ
assert resource['status']['automaticFailover'] == "enabled"
assert resource['status']['multiAZ'] == "enabled"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gustavodiaz7722 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants