Skip to content

Conversation

knottnt
Copy link
Contributor

@knottnt knottnt commented Oct 1, 2025

Issue #, if available: 2450

Description of changes:
Update the OpenID Connect Provider resource to late initialize the Thumbprints field when not provided. This avoids invalid requests being made to UpdateOpenIDConnectProviderThumbprint due to the Thumbprints field being nil.

  • Mark OpenIDConnectProvider.Thumbprints as a late_initialize field in generator.yaml
  • Add e2e test to verify that the Thumbprints field is populated with the value in AWS following creation of the resource and that subsequent reconcile doesn't trigger an invalid UpdateOpenIDConnectProviderThumbprint request.
  • Add .vscode to .gitignore

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Mark the ThumbPrints field for OpenID Connect Provider as late_initialize

- Rebuild iam-controller with latest code-generator
@ack-prow ack-prow bot requested review from michaelhtm and rushmash91 October 1, 2025 18:06
@ack-prow ack-prow bot added the approved label Oct 1, 2025
Copy link

ack-prow bot commented Oct 1, 2025

@knottnt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-verify-attribution e23b8fe link false /test iam-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rushmash91
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
Copy link

ack-prow bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 79b2e7a into aws-controllers-k8s:main Oct 3, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants