Release artifacts for v0.0.3 #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
michaelhtm
pushed a commit
to rushmash91/lambda-controller
that referenced
this pull request
Feb 5, 2025
…ntrollers-k8s#16) Issue aws-controllers-k8s/community#831 This patch adds new generator hooks for `sdkFind` and `sdkUpdate` methods. For `sdkFind` the hook will requeue the reconcillation after 30seconds if a `broker` status is still in `CREATION_IN_PROGRESS`. For `sdkUpdate` the hook will create a copy of latest `ko` Status into the the desired one before proceeding in copying the update response fields into the desired `ko`. There are two reasons why we need to copy the CR Status: - `updateBroker` api call only returns the `BrokerID` and dosen't return information about the broker state. - the desired `ko` status is a copy of the observed state by the API server, which will contain `CREATION_IN_PROGRESS` brokerState in the CR Status. Description of changes: - Update runtime version to `v0.2.3` - regenerate controller using `ack-generate` v0.2.3 - Add a post read one hook to requeue whenever a broker is still in `CREATION_IN_PROGRESS` state By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
v0.0.3By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.