Prevent GetFunctionCodeSigningConfig calls when a functions packageType is Image
#21
Conversation
|
@a-hilaly where do we stand with this PR? :) |
This PR will need more work than expected. We will need proper support for Images based lambda functions (Initializers, custom hooks and proper e2e for it). |
|
/hold |
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
issue/1117
branch
2 times, most recently
from
911b61e to
2f08b31
Compare
a-hilaly
force-pushed
the
issue/1117
branch
2 times, most recently
from
0678a82 to
255650e
Compare
|
/retest |
|
Do you know the timeline for this to be merged? We switched to using image based Function because currently S3 Key change updates are not supported. |
@gagan-eg very soon :) |
|
/retest |
ack-bot
removed
the
do-not-merge/hold
|
/test lambda-kind-e2e |
|
@a-hilaly looking at the failure in the e2e test, I think you need to add terminal codes to the |
a-hilaly
force-pushed
the
issue/1117
branch
2 times, most recently
from
b25dcbb to
cda221d
Compare
|
/retest |
1 similar comment
|
/retest |
a-hilaly
force-pushed
the
issue/1117
branch
2 times, most recently
from
54941f8 to
4b241ff
Compare
…en a functions packageType is `Image` Functions code signing config should only be called when a function is created using an s3bucket and a key. Functions created using a container image cannot get a code signing configuration.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, jaypipes, vijtrip2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
### Update ACK runtime to `v0.14.1` #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building mq-controller ==== Copying common custom resource definitions into mq Building Kubernetes API objects for mq Generating deepcopy code for mq Generating custom resource definitions for mq Building service controller for mq Generating RBAC manifests for mq Running gofmt against generated code for mq Updating additional GitHub repository maintenance files ==== building mq-controller release artifacts ==== Building release artifacts for mq-v0.0.5 Generating common custom resource definitions Generating custom resource definitions for mq Generating RBAC manifests for mq ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue #, if available: aws-controllers-k8s/community#1117
Description of changes:
Functions code signing config should only be called when a function is
created using an s3bucket and a key. Functions created using a container
image cannot get a code signing configuration.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.