Bump aws-sdk-go version to v1.44.60
#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ack-bot
added
the
do-not-merge/hold
a-hilaly
force-pushed
the
bump-sdk
branch
2 times, most recently
from
64e1db5 to
9825d78
Compare
a-hilaly
commented
Aug 14, 2022
Comment on lines
+2
to
+4
| // We need to carefully craft the update request if a user | ||
| // wants to delete their filterCriterias. Mainly because the | ||
| // aws-sdk-go doesn't try to update nil fields. |
There was a problem hiding this comment.
I'm thinking that this is something we should handle for all CRs that have nested structs fields...
a-hilaly
commented
Aug 14, 2022
Comment on lines
+146
to
+152
| # Delete the filterCriteria field | ||
| cr = k8s.wait_resource_consumed_by_controller(ref) | ||
| cr["spec"]["filterCriteria"] = None | ||
|
|
||
| # Patch k8s resource | ||
| k8s.patch_custom_resource(ref, cr) | ||
| time.sleep(UPDATE_WAIT_AFTER_SECONDS) |
There was a problem hiding this comment.
This patch doesn't work if i use del cr["spec"]["filterCriteria"] 😕
- Bump aws-sdk-go version to v1.44.60 - Ignores the newly released resource `FunctionUrlConfig` - Adds ephemeral storage to `Function` resource - Adds `FilterCriteria` to `EventSourceMapping` resource - Adds hooks for to properly handle `FilterCriteria` changes - Reduces the wait time for `EventSourceMapping` resources - Add test cases for the newly added fields. Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
|
/unhold |
ack-bot
removed
the
do-not-merge/hold
michaelhtm
pushed a commit
to rushmash91/lambda-controller
that referenced
this pull request
Feb 5, 2025
…llers-k8s#39) ### Update to ACK runtime `v0.18.1`, code-generator `v0.18.2` ---------- * ACK code-generator `v0.18.2` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.18.2) * ACK runtime `v0.18.1` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.18.1) ---------- NOTE: This PR increments the release version of service controller from `v0.0.15` to `v0.0.16` Once this PR is merged, release `v0.0.16` will be automatically created for `mq-controller` **Please close this PR, if you do not want the new patch release for `mq-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. installing controller-gen v0.7.0 ... ok. ==== building mq-controller ==== Copying common custom resource definitions into mq Building Kubernetes API objects for mq Generating deepcopy code for mq Generating custom resource definitions for mq Building service controller for mq Generating RBAC manifests for mq Running gofmt against generated code for mq Updating additional GitHub repository maintenance files ==== building mq-controller release artifacts ==== Building release artifacts for mq-v0.0.16 Generating common custom resource definitions Generating custom resource definitions for mq Generating RBAC manifests for mq ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
FunctionUrlConfigFunctionresourceFilterCriteriatoEventSourceMappingresourceFilterCriteriachangesEventSourceMappingresourcesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.