Skip to content

Add ECR and S3 ReadOnly access to the recommended policy #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Aug 9, 2022

Signed-off-by: Amine Hilaly hilalyamine@gmail.com

Add ECR and S3 ReadOnly access to the recommended policy for
lambda-controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lambda-controller

Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
@a-hilaly a-hilaly force-pushed the update-recommended-policy branch from a2b7aa5 to 9504ea7 Compare August 9, 2022 22:30
Copy link
Contributor

@vijtrip2 vijtrip2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, vijtrip2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 65365f0 into aws-controllers-k8s:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants