Skip to content

Conversation

acornett21
Copy link
Contributor

Issue #, if available:
NA

Description of changes:
Removing the dev preview verbiage from the OLM config file in preparation for this controller to go GA

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Adam D. Cornett adc@redhat.com

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@ack-bot ack-bot requested review from jaypipes and vijtrip2 August 22, 2022 14:47
@ack-bot ack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 22, 2022

Hi @acornett21. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

a-hilaly commented Sep 6, 2022

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, acornett21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit b6485f6 into aws-controllers-k8s:main Sep 6, 2022
michaelhtm pushed a commit to rushmash91/lambda-controller that referenced this pull request Feb 5, 2025
…llers-k8s#45)

### Update to ACK runtime `v0.19.3`, code-generator `v0.19.3`

----------

* ACK code-generator `v0.19.3` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.19.3)
* ACK runtime `v0.19.3` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.19.3)

----------

NOTE:
This PR increments the release version of service controller from `v0.0.19` to `v0.0.20`

Once this PR is merged, release `v0.0.20` will be automatically created for `mq-controller`

**Please close this PR, if you do not want the new patch release for `mq-controller`**

----------

#### stdout for `make build-controller`:

```
building ack-generate ... ok.
==== building mq-controller ====
Copying common custom resource definitions into mq
Building Kubernetes API objects for mq
Generating deepcopy code for mq
Generating custom resource definitions for mq
Building service controller for mq
Generating RBAC manifests for mq
Running gofmt against generated code for mq
Updating additional GitHub repository maintenance files
==== building mq-controller release artifacts ====
Building release artifacts for mq-v0.0.20
Generating common custom resource definitions
Generating custom resource definitions for mq
Generating RBAC manifests for mq
```

----------

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants