Support Function references in Alias resource
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling the changes
jaypipes
suggested changes
Sep 15, 2022
There was a problem hiding this comment.
Hi @Vandita2020! Thanks very much for this contribution! May I ask that you update the commit message and pull request summary to mention that you are adding functionality to the lambda controller to be able to reference a Function from an Alias resource using resource references?
Thank you!
-jay
a-hilaly
reviewed
Sep 15, 2022
There was a problem hiding this comment.
Nice start on this @Vandita2020 ! I left two tiny comments inline.
Vandita2020
force-pushed
the
alias_ref
branch
from
1d7c9b0 to
1f46baf
Compare
|
Nice work on this, thank you @Vandita2020 ! |
|
/lgtm cancel |
a-hilaly
reviewed
Sep 16, 2022
apis/v1alpha1/generator.yaml
Outdated
| is_primary_key: true |
There was a problem hiding this comment.
Suggested change
| is_primary_key: true | |
| is_primary_key: true |
Vandita2020
force-pushed
the
alias_ref
branch
from
1f46baf to
16e64f5
Compare
Vandita2020
force-pushed
the
alias_ref
branch
from
16e64f5 to
f80f4ad
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, Vandita2020 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Vandita2020
added a commit
to Vandita2020/ack-lambda-controller
that referenced
this pull request
Sep 26, 2022
…s#53) Issue #, if available: Description of changes: Adding functionality to the lambda controller to be able to reference a `Function` from an `Alias` resource using resource references. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
michaelhtm
pushed a commit
to rushmash91/lambda-controller
that referenced
this pull request
Feb 5, 2025
…llers-k8s#53) ### Update to ACK runtime `v0.21.0`, code-generator `v0.21.0` ---------- * ACK code-generator `v0.21.0` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.21.0) * ACK runtime `v0.21.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.21.0) ---------- NOTE: This PR increments the release version of service controller from `v0.0.23` to `v0.0.24` Once this PR is merged, release `v0.0.24` will be automatically created for `mq-controller` **Please close this PR, if you do not want the new patch release for `mq-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building mq-controller ==== Copying common custom resource definitions into mq Building Kubernetes API objects for mq Generating deepcopy code for mq Generating custom resource definitions for mq Building service controller for mq Generating RBAC manifests for mq Running gofmt against generated code for mq Updating additional GitHub repository maintenance files ==== building mq-controller release artifacts ==== Building release artifacts for mq-v0.0.24 Generating common custom resource definitions Generating custom resource definitions for mq Generating RBAC manifests for mq ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1394
Description of changes:
Adding functionality to the lambda controller to be able to reference a
Functionfrom anAliasresource using resource references.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.