Skip to content

Conversation

Vandita2020
Copy link
Member

@Vandita2020 Vandita2020 commented Sep 26, 2022

Issue #, if available:
#1394

Description of changes:
Adding functionality to the lambda controller to be able to reference a Function from a EventSourceMappingSQS resource using resource references.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@a-hilaly a-hilaly force-pushed the event_source_mapping_sqs_ref branch 3 times, most recently from b298eba to 1d70b94 Compare September 28, 2022 23:09
@Vandita2020 Vandita2020 force-pushed the event_source_mapping_sqs_ref branch 2 times, most recently from 43c1784 to b2e19a2 Compare September 29, 2022 18:02
@Vandita2020 Vandita2020 force-pushed the event_source_mapping_sqs_ref branch from b2e19a2 to ae916f6 Compare September 29, 2022 18:05
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you @Vandita2020 !
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, Vandita2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit 2b41b1d into aws-controllers-k8s:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants