Skip to content

Add Alias resource #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Conversation

a-hilaly
Copy link
Member

@a-hilaly a-hilaly commented Nov 15, 2021

Issue aws-controllers-k8s/community#238

Description of changes:

  • Adds create, delete and update operations for Alias resource in the
    AWS Lambda API.
  • Adds end2end tests to deploy lambda aliases using ACK controller.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from jaypipes and vijtrip2 November 15, 2021 19:30
@a-hilaly a-hilaly force-pushed the aliases-resources branch 2 times, most recently from 155d5f3 to e489b3c Compare November 15, 2021 19:38
Issue: aws-controllers-k8s/community#238

Adds create, delete and update operations for Alias resource in the
AWS Lambda API.
Adds end2end tests to deploy lambda aliases using ACK controller.
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy bueno, gracias @a-hilaly!

@jaypipes
Copy link
Contributor

/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@ack-bot
Copy link
Collaborator

ack-bot commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, jaypipes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit cdd33c9 into aws-controllers-k8s:main Nov 15, 2021
a-hilaly added a commit to a-hilaly/ack-lambda-controller that referenced this pull request Nov 18, 2021
Issue aws-controllers-k8s/community#238

Description of changes:
- Adds create, delete and update operations for `Alias` resource in the
AWS Lambda API.
- Adds end2end tests to deploy lambda aliases using ACK controller.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
michaelhtm pushed a commit to rushmash91/lambda-controller that referenced this pull request Feb 5, 2025
…quirements

Cleans the requirements.txt file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants