Skip to content

Add function's EphemeralStorage update support #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Add function's EphemeralStorage update support #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/resource/function/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,15 @@ func (rm *resourceManager) updateFunctionConfiguration(
input.VpcConfig = VPCConfig
}

if delta.DifferentAt("Spec.EphemeralStorage") {
ephemeralStorage := &svcsdk.EphemeralStorage{}
if dspec.EphemeralStorage != nil {
ephemeralStorageCopy := dspec.EphemeralStorage.DeepCopy()
ephemeralStorage.Size = ephemeralStorageCopy.Size
}
input.EphemeralStorage = ephemeralStorage
}

_, err = rm.sdkapi.UpdateFunctionConfigurationWithContext(ctx, input)
rm.metrics.RecordAPICall("UPDATE", "UpdateFunctionConfiguration", err)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/tests/test_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def test_function_package_type_image(self, lambda_client):
assert lambda_validator.function_exists(resource_name)

cr["spec"]["timeout"] = 10
cr["spec"]["ephemeralStorage"] = { "size" : 512 }
cr["spec"]["ephemeralStorage"] = { "size" : 1024 }

# Patch k8s resource
k8s.patch_custom_resource(ref, cr)
Expand All @@ -341,7 +341,7 @@ def test_function_package_type_image(self, lambda_client):
# Check function updated fields
function = lambda_validator.get_function(resource_name)
assert function["Configuration"]["Timeout"] == 10
assert function["Configuration"]["EphemeralStorage"]["Size"] == 512
assert function["Configuration"]["EphemeralStorage"]["Size"] == 1024

# Delete k8s resource
_, deleted = k8s.delete_custom_resource(ref)
Expand Down