Skip to content

Conversation

kyriechen96
Copy link
Contributor

Description of changes:
Merges all hooks in each resource into a single hook file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-bot ack-bot requested review from nmvk and vijtrip2 December 6, 2022 15:11
@kyriechen96
Copy link
Contributor Author

/retest

4 similar comments
@kyriechen96
Copy link
Contributor Author

/retest

@kyriechen96
Copy link
Contributor Author

/retest

@kyriechen96
Copy link
Contributor Author

/retest

@kyriechen96
Copy link
Contributor Author

/retest

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Thank you so much @kyriechen96
/lgtm

@ack-bot ack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@ack-bot
Copy link
Collaborator

ack-bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, kyriechen96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-bot ack-bot merged commit eb5b829 into aws-controllers-k8s:main Dec 7, 2022
kyriechen96 added a commit to kyriechen96/memorydb-controller that referenced this pull request Dec 8, 2022
Description of changes:
Merges all hooks in each resource into a single hook file.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants