Skip to content

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Dec 14, 2023

Update to ACK runtime v0.28.0, code-generator v0.28.0



NOTE:
This PR increments the release version of service controller from v1.0.5 to v1.0.6

Once this PR is merged, release v1.0.6 will be automatically created for sns-controller

Please close this PR, if you do not want the new patch release for sns-controller


stdout for make build-controller:

building ack-generate ... ok.
==== building sns-controller ====
Copying common custom resource definitions into sns
Building Kubernetes API objects for sns
Generating deepcopy code for sns
Generating custom resource definitions for sns
Building service controller for sns
Generating RBAC manifests for sns
Running gofmt against generated code for sns
Updating additional GitHub repository maintenance files
==== building sns-controller release artifacts ====
Building release artifacts for sns-v1.0.6
Generating common custom resource definitions
Generating custom resource definitions for sns
Generating RBAC manifests for sns

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
Copy link

ack-prow bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, ack-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 14, 2023
@ack-prow ack-prow bot merged commit 9b81a2d into main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack-bot-autogen approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants