Skip to content

fix: tracing subsegment when using fluent api Tracing.WithSubsegment #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: tracing subsegment when using fluent api Tracing.WithSubsegment #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b9360
fix: tracing subsegment when using fluent api Tracing.WithSubsegment
hjgraca Oct 8, 2025
709ef3f
revert example change, it will break before the new release is out an…
hjgraca Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions libraries/src/AWS.Lambda.Powertools.Tracing/Tracing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,20 @@ public static void WithSubsegment(string nameSpace, string name, Action<TracingS
XRayRecorder.Instance.SetNamespace(GetNamespaceOrDefault(nameSpace));
try
{
var entity = XRayRecorder.Instance.GetEntity() as TracingSubsegment;
subsegment?.Invoke(entity);
var entity = XRayRecorder.Instance.GetEntity();
var tracingSubsegment = new TracingSubsegment("## " + name);

// Copy properties from the current entity
if (entity != null)
{
if (entity is Subsegment subsegmentEntity)
{
tracingSubsegment.Namespace = subsegmentEntity.Namespace;
}
tracingSubsegment.Sampled = entity.Sampled;
}

subsegment?.Invoke(tracingSubsegment);
}
finally
{
Expand Down
Loading
Loading