Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: introduce nox to test optional dependencies #4501

Closed
17 of 18 tasks
heitorlessa opened this issue Jun 13, 2024 · 3 comments
Closed
17 of 18 tasks

Maintenance: introduce nox to test optional dependencies #4501

heitorlessa opened this issue Jun 13, 2024 · 3 comments
Assignees
Labels
internal Maintenance changes tests

Comments

@heitorlessa
Copy link
Contributor

heitorlessa commented Jun 13, 2024

Why is this needed?

Today's release suffered a regression due to static typing accidentally requiring an optional dependency for customers.

We must not make any release until we have a safeguard to prevent this in the future.

#4498

Update with task list - 14/06

Which area does this relate to?

No response

Solution

Use nox, or create new workflows where we test bare dependencies, and every optional dependencies.

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Jun 13, 2024
@leandrodamascena
Copy link
Contributor

Assigning to me.

@leandrodamascena leandrodamascena self-assigned this Jun 13, 2024
@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Jun 13, 2024
@leandrodamascena
Copy link
Contributor

Introducing nox requires a lot of changes to our tests and can easily become a PR with hundreds of lines of changes. So I'll break this down into small PRs to make reviewing easier.

Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes tests
Projects
Status: Coming soon
Development

No branches or pull requests

2 participants