Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Fix codecov upload - missing token #4681

Closed
2 tasks done
hjgraca opened this issue Jul 3, 2024 · 2 comments
Closed
2 tasks done

Maintenance: Fix codecov upload - missing token #4681

hjgraca opened this issue Jul 3, 2024 · 2 comments
Labels
internal Maintenance changes triage Pending triage from maintainers

Comments

@hjgraca
Copy link
Contributor

hjgraca commented Jul 3, 2024

Why is this needed?

After Codecov v4 release a token is required to upload the reports. Currently is working only of forked pull request, but failing on other pull requests.
Docs: https://github.com/codecov/codecov-action
image

Error: https://github.com/aws-powertools/powertools-lambda-python/actions/runs/9773715912/job/26980442993#step:12:40

image

Which area does this relate to?

Automation

Solution

Docs https://about.codecov.io/blog/january-product-update-updating-the-codecov-ci-uploaders-to-the-codecov-cli/

  • add token to quality_check codecov upload here
  • Add CODECOV_TOKEN secret to GitHub secrets

Acknowledgment

@hjgraca hjgraca added triage Pending triage from maintainers internal Maintenance changes labels Jul 3, 2024
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Copy link
Contributor

This is now released under 2.41.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes triage Pending triage from maintainers
Projects
Status: Coming soon
Development

No branches or pull requests

2 participants