Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-perf): use pytest-benchmark to improve reliability #1250

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Jun 17, 2022

Issue number: #1009

Summary

Replace simple perf test for core utilities import and init time with pytest-benchmark using pedantic mode.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file tests labels Jun 17, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2022
@github-actions github-actions bot added the internal Maintenance changes label Jun 17, 2022
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #1250 (f240dfa) into develop (d1b8e83) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1250   +/-   ##
========================================
  Coverage    99.88%   99.88%           
========================================
  Files          119      119           
  Lines         5423     5423           
  Branches       618      618           
========================================
  Hits          5417     5417           
  Misses           2        2           
  Partials         4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e1c5c...f240dfa. Read the comment docs.

@heitorlessa heitorlessa merged commit 5fbff55 into aws-powertools:develop Jun 17, 2022
@heitorlessa heitorlessa deleted the chore/rerun-perf-test-ci branch June 17, 2022 12:57
heitorlessa added a commit that referenced this pull request Jun 17, 2022
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  chore(test-perf): use pytest-benchmark to improve reliability (#1250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants