Skip to content

docs(idempotency): fixes to testing your code section #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 5, 2023
Merged

docs(idempotency): fixes to testing your code section #2073

merged 8 commits into from
Apr 5, 2023

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #2072

Summary

Fix local test example

Changes

  • Changed documentation

User experience

Before
image

After
image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner March 30, 2023 23:56
@leandrodamascena leandrodamascena requested review from heitorlessa and removed request for a team March 30, 2023 23:56
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Mar 30, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 30, 2023
heitorlessa
heitorlessa reviewed Mar 31, 2023
View reviewed changes
@heitorlessa heitorlessa changed the title docs(idempotency): fix local test example TEST[docs(idempotency): fix local test example Apr 3, 2023
@heitorlessa heitorlessa changed the title TEST[docs(idempotency): fix local test example WIP docs(idempotency): fix local test example Apr 3, 2023
@heitorlessa heitorlessa changed the title WIP docs(idempotency): fix local test example docs(idempotency): fix local test example Apr 3, 2023
@heitorlessa heitorlessa linked an issue Apr 3, 2023 that may be closed by this pull request
Docs: Fix local tests example in the Idempotency Testing Your Code section #2072
Closed
1 task
@leandrodamascena
Copy link
Contributor Author

I am moving the comment from issue to PR.
Refer: #2072 (comment)

Heitor Lessa:
only last comment before merging is that this part shouldn't work, please double check in case I'm wrong: #2073 (files)
Reason. Unless AWS SDK changed, the DynamoDB client wouldn't connect to DynamoDB Local because the client isn't being replaced, therefore it'd use the real DynamoDB external endpoint

Yeah @heitorlessa, you're right! I was missing it because in my local tests, I was configuring the boto3.session in the app.py file and I forgot to remove it. My bad. I already sent the new code.

@heitorlessa heitorlessa mentioned this pull request Apr 5, 2023
Merged
7 tasks
@heitorlessa
Copy link
Contributor

heitorlessa commented Apr 5, 2023 •
edited
Loading

@leandrodamascena created PR exposing the SDK Client and accepting a custom SDK client so customers can do this more cleanly.

I'll let you review, once merged, then we can finish this one.

#2087

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Apr 5, 2023
@heitorlessa
Merge branch 'develop' into doc/idempotency-client
b79d7d3 
* develop:
  feat(idempotency): allow custom sdk clients in DynamoDBPersistenceLayer (#2087)
  chore(deps-dev): bump types-python-dateutil from 2.8.19.11 to 2.8.19.12 (#2085)
  chore(deps-dev): bump cfn-lint from 0.76.1 to 0.76.2 (#2084)
  chore(deps-dev): bump aws-cdk from 2.72.0 to 2.72.1 (#2081)
  chore(deps): bump aws-xray-sdk from 2.11.0 to 2.12.0 (#2080)
  update changelog with latest changes
  docs(parser): fix highlighted line (#2064)
@heitorlessa
docs: fix mock example; use new public client attr
9ebac42
@heitorlessa heitorlessa changed the title docs(idempotency): fix local test example docs(idempotency): fixes to testing your code section Apr 5, 2023
@heitorlessa heitorlessa removed the pending-release Fix or implementation already in dev waiting to be released label Apr 5, 2023
@heitorlessa heitorlessa merged commit 1f92c59 into aws-powertools:develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@rubenfonseca rubenfonseca rubenfonseca approved these changes

@heitorlessa heitorlessa heitorlessa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Fix local tests example in the Idempotency Testing Your Code section
3 participants
@leandrodamascena @heitorlessa @rubenfonseca