Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(project): rename project to Powertools for AWS Lambda (Python) #2313

Merged
merged 5 commits into from
May 31, 2023

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented May 23, 2023

Issue number: #2302

Summary

Changes

Please provide a summary of what's being changed

Renames the project to Powertools for AWS Lambda (Python)

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team as a code owner May 23, 2023 10:37
@sthulb sthulb requested review from leandrodamascena and removed request for a team May 23, 2023 10:37
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code github-templates internal Maintenance changes logger tests labels May 23, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2023
@rubenfonseca
Copy link
Contributor

Hi @sthulb it seems some linting checks are failing. Did you ran make pr before submitting the PR?

@sthulb sthulb marked this pull request as draft May 23, 2023 13:59
Signed-off-by: Simon Thulbourn <sthulb@users.noreply.github.com>
@sthulb
Copy link
Contributor Author

sthulb commented May 23, 2023

@rubenfonseca fixed – sorry.

@leandrodamascena leandrodamascena linked an issue May 24, 2023 that may be closed by this pull request
@leandrodamascena leandrodamascena changed the title chore: rename project to Powertools for AWS Lambda (Python) docs(project): rename project to Powertools for AWS Lambda (Python) May 24, 2023
@leandrodamascena leandrodamascena marked this pull request as ready for review May 30, 2023 14:06
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @sthulb! I just sent a commit with small changes and this is approved!!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (f00eeab) 97.47% compared to head (a4560cc) 97.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2313   +/-   ##
========================================
  Coverage    97.47%   97.47%           
========================================
  Files          150      150           
  Lines         6925     6925           
  Branches       509      509           
========================================
  Hits          6750     6750           
  Misses         137      137           
  Partials        38       38           
Impacted Files Coverage Δ
aws_lambda_powertools/logging/formatter.py 100.00% <ø> (ø)
aws_lambda_powertools/logging/logger.py 99.42% <ø> (ø)
aws_lambda_powertools/logging/utils.py 100.00% <ø> (ø)
aws_lambda_powertools/package_logger.py 100.00% <ø> (ø)
...mbda_powertools/utilities/validation/exceptions.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leandrodamascena leandrodamascena merged commit c6fb0b4 into develop May 31, 2023
7 checks passed
@leandrodamascena leandrodamascena deleted the rename branch May 31, 2023 07:56
roger-zhangg pushed a commit to roger-zhangg/aws-lambda-powertools-python that referenced this pull request Jun 5, 2023
…ws-powertools#2313)

Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code github-templates internal Maintenance changes logger size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming of Lambda Powertools
4 participants