refactor(event-handler): api gateway handler review changes #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enum to match code style (PascalCase) - Keep not found only in message return for security reasons - Remove Tuple type of response to keep it simpler (Dict and Response only)
|
@heitorlessa i make the recommended changes from : #418 |
heitorlessa
approved these changes
May 4, 2021
heitorlessa
referenced
this pull request
in heitorlessa/aws-lambda-powertools-python
May 5, 2021
…tools-python into docs/event-handler-http * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: refactor(event-handler): api gateway handler review changes (#420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#418
Description of changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.