feat(feature-flags): improve "IN/NOT_IN"; new rule actions #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/utilities
documentation
pull-request-size
bot
added
the
size/L
gwlester
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #710 +/- ##
===========================================
- Coverage 99.97% 99.93% -0.05%
===========================================
Files 116 116
Lines 4866 4902 +36
Branches 267 271 +4
===========================================
+ Hits 4865 4899 +34
- Misses 0 1 +1
- Partials 1 2 +1
Continue to review full report at Codecov.
|
|
Thanks a lot for helping expand the Feature flags utility @gwlester -- I find it much cleaner now. Updating other areas like Schema docstring, and making a list of areas that we will deprecate when we go GA. |
heitorlessa
changed the title
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Oct 1, 2021
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(feature-flags): improve "IN/NOT_IN"; new rule actions (aws-powertools#710) feat(idempotency): makes customers unit testing easier (aws-powertools#719) feat(feature-flags): get_raw_configuration property in Store (aws-powertools#720)
heitorlessa
added a commit
to gwlester/aws-lambda-powertools-python
that referenced
this pull request
Oct 1, 2021
* develop: feat(feature-flags): improve "IN/NOT_IN"; new rule actions (aws-powertools#710) feat(idempotency): makes customers unit testing easier (aws-powertools#719) feat(feature-flags): get_raw_configuration property in Store (aws-powertools#720) feat: boto3 sessions in batch, parameters & idempotency (aws-powertools#717) feat: add get_raw_configuration property in store; expose store fix(mypy): a few return types, type signatures, and untyped areas (aws-powertools#718) docs: Terraform reference for SAR Lambda Layer (aws-powertools#716) chore(deps-dev): bump flake8-bugbear from 21.9.1 to 21.9.2 (aws-powertools#712) chore(deps): bump boto3 from 1.18.49 to 1.18.51 (aws-powertools#713) fix(idempotency): sorting keys before hashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added new conditions for contains that clarify what they are testing.
Checklist
Breaking change checklist
RFC issue #699:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
View rendered docs/utilities/feature_flags.md