-
Notifications
You must be signed in to change notification settings - Fork 454
feat(parser): add field metadata and examples for CloudWatch models #7343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parser): add field metadata and examples for CloudWatch models #7343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sreejaaryahi18 please run make format
before pushing a commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @sreejaaryahi18! Approved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7343 +/- ##
========================================
Coverage 96.36% 96.36%
========================================
Files 275 275
Lines 13007 13007
Branches 968 968
========================================
Hits 12534 12534
Misses 366 366
Partials 107 107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue number: closes #7121
Summary
Improved the documentation for the CloudWatch parser models by adding descriptions and example values to the fields using Pydantic's Field() function.
Changes
User experience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.