docs(aws): add AWS docs bootstrap JavaScript #7472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
boring-cyborg
bot
added
the
documentation
|
Can I have your review here @phipag ? Thanks |
phipag
suggested changes
Oct 3, 2025
|
|
LGTM |
phipag
approved these changes
Oct 3, 2025
leandrodamascena
requested review from
dreamorosi
and removed request for
anafalcao
dreamorosi
approved these changes
Oct 3, 2025
dreamorosi
reviewed
Oct 4, 2025
Comment on lines
-15
to
-19
| function copyToClipboard(e) { | ||
| e.preventDefault() | ||
| navigator.clipboard.writeText(e.target.textContent) | ||
| alert$.next("Copied to clipboard") | ||
| } |
There was a problem hiding this comment.
Sorry for the late comment, I just noticed this while making the same change on TS.
This function, as well as L52-57, L59-62, L64, L74-75, and L91 should have been kept as I think they provide the copy to clipboard feature in the layers docs.
See aws-powertools/powertools-lambda-typescript#4614 for how the file looks like, if you want to copy it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: closes #7471
Summary
Changes
Add JS scripts to support AWS docs.
User experience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.