refactor(logger): mark private members as readonly and fix code quality issues #4350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
boring-cyborg
bot
added
logger
|
svozza
approved these changes
Aug 18, 2025
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR improves code quality in the logger package by adding
readonlymodifiers to class members that are never reassigned after initialization, removing redundant code structures, and cleaning up unused collections in test files.Note: The SonarQube issue AZItlgwecEUs2753LD68 for
sampling.test.ts #sampleRateValuewas not addressed as the relevant code was already removed in PR #4251.Issue number: closes #4255
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.