-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Cluster Access Management API on Security #919
Conversation
✅ Deploy Preview for eks-workshop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @rodrigobersa ! I'm noticing quite a few of the pages have blank terminal sections showing like this: To fix the pre-commit warnings you can either set up pre-commit or run this from the top level directory:
It should modify a bunch of files. |
Hey @niallthomson ! Yes, I created the whole content o Quip and ported to Git yesterday. I'll fix those issues today. Also thanks for the tip for the pre-commit fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that the overall flow of this lab is based on some mistaken assumptions and the way we're modifying the cluster is a little risky.
For example, the content states that if you delete the cluster creator role then you don't have access to the cluster because it assumes CodeBuild creates the cluster, but in self-service mode this is not true.
I'd also prefer to avoid modifying/deleting the cluster creator role and its access. I think we should focus on just introducing new IAM roles (like EKSDevelopers) and adding access entries for these with different permissions.
Instead of using update-kubeconfig
to overwrite the kubeconfig file every time I'd suggest we use something like:
aws eks update-kubeconfig --name $EKS_CLUSTER_NAME --role-arn arn:aws:iam::$AWS_ACCOUNT_ID:role/EKSDevelopers --alias developers --user-alias developers
kubectl --context developers get pod -A
This means that the original kubeconfig entries remain in place, which feels less risky to me.
Personally my suggested flow would be:
- Show how to provide cluster admin access to a new role called EKSAdmins. Do not interfere with the original cluster creator roles or access.
- Show how to provide read-only access to a new role called EKSReadOnly. This is basically the above but shows the limitations of the access provided.
- Show how to map a role to a Kubernetes group. Suggest using EKSDevelopers and creating a new Kubernetes RBAC group, rolebindings etc. Then demonstrate the very specific access that they have.
What this PR does / why we need it:
Walkthrough of using Cluster Access Management API replacing
aws-auth
to provide access to the cluster. The module covers;aws-auth
based identity mappingsQuality checks
make test module="<module>"
it was successful (see https://github.com/aws-samples/eks-workshop-v2/blob/main/docs/automated_tests.md)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.