Feature/dynamic accounts setup (#2) #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update README for infra repository * update READMEs and the diagrams * remove some constant values * removing loaded account ids from config * add new template option for dynamic accounts through cfn params - add more to README - rename stagin to preprod - remove space from folder name - remove account specific details * add comments to constants.py * update script to handle updating constants.py * adding minor detail Co-authored-by: Fatema Alkhanaizi <alkhanai@amazon.co.uk>
|
Thanks for the updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
update README for infra repository
update READMEs and the diagrams
remove some constant values
removing loaded account ids from config
add new template option for dynamic accounts through cfn params
add comments to constants.py
update script to handle updating constants.py
adding minor detail
Co-authored-by: Fatema Alkhanaizi alkhanai@amazon.co.uk
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.