Add s3-sqs-lambda-terraform pattern #2360

enmata · 2024-07-08T07:24:21Z

Issue #, if available:
Adding s3-sqs-lambda-terraform pattern

Description of changes:
Adding the terraform version of Add s3-sqs-lambda pattern
https://serverlessland.com/patterns/s3-sqs-lambda?ref=search

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

example-pattern.json

bfreiberg · 2024-07-08T11:02:43Z

Hi @enmata and thanks for the PR. We already have two Terraform patterns that cover this behaviour: S3 -> SQS (https://serverlessland.com/patterns/s3-sqs-cdk-terraform) and SQS -> Lambda (https://serverlessland.com/patterns/sqs-lambda-terraform-python).
As patterns are supposed to be small, independent buildings builds I don't see any additional value in this submission.

bfreiberg · 2024-07-08T13:05:52Z

s3-sqs-lambda-terraform/README.md

@@ -0,0 +1,81 @@
+# AWS Amazon S3 Lambda with SQS queue


Suggested change

# AWS Amazon S3 Lambda with SQS queue

# Amazon S3 to Amaozn SQS queue to AWS Lambda

There is a "to" missing after S3

bfreiberg · 2024-07-08T13:10:38Z

s3-sqs-lambda-terraform/README.md

@@ -0,0 +1,81 @@
+# AWS Amazon S3 Lambda with SQS queue
+
+The terraform manifest deploys a Lambda function, an SQS queue, one S3 buckets and the IAM resources required to run the application. Create a Lambda function that is triggered on every new jpg image file stored on s3 Bucket using SQS as a notification target. The Lambda app acts as a Boilerplate code.


Suggested change

The terraform manifest deploys a Lambda function, an SQS queue, one S3 buckets and the IAM resources required to run the application. Create a Lambda function that is triggered on every new jpg image file stored on s3 Bucket using SQS as a notification target. The Lambda app acts as a Boilerplate code.

The Terraform code deploys an AWS Lambda function, an Amazon SQS queue, one AWS S3 buckets and the AWS IAM resources required to run the application. The created Lambda function is triggered on every new `.jpg` image file uploaded to the S3 bucket using an SQS queue as a notification target. The Lambda function code contains only contains minimal code for demo purposes.

I don't see this changed in the latest commit, did you forget to include it?

Sorry, updated.

bfreiberg · 2024-07-08T13:11:23Z

s3-sqs-lambda-terraform/README.md

+## How it works
+
+* Use the AWS CLI or AWS console to upload an image to the source S3 Bucket
+* If the object is a .jpg the code, a Lambda that is triggered using SQS as a notification target. 


Suggested change

* If the object is a .jpg the code, a Lambda that is triggered using SQS as a notification target.

* If the object is a .jpg file, the Lambda function is triggered using SQS as a notification target.

I don't see this changed in the latest commit, did you forget to include it?

Sorry, updated.

bfreiberg · 2024-07-08T13:14:03Z

s3-sqs-lambda-terraform/README.md

+
+## Testing
+
+Run the following S3 CLI command to upload an image to the S3 bucket. Note, you must edit the {SourceBucketName} placeholder with the name of the source S3 Bucket. This is provided in the stack outputs.


Suggested change

Run the following S3 CLI command to upload an image to the S3 bucket. Note, you must edit the {SourceBucketName} placeholder with the name of the source S3 Bucket. This is provided in the stack outputs.

Run the following AWS CLI command to upload an image to the S3 bucket. Note, you must edit the {SourceBucketName} placeholder with the name of the source S3 bucket. This is provided in the stack outputs.

Sorry, updated.

bfreiberg · 2024-07-08T13:14:29Z

s3-sqs-lambda-terraform/README.md

+
+## Documentations and next step
+
+To create a full Step Functions workflow with the pattern created, you can find out example workflows at Step Functions Workflow: [serverlessland.com/workflows](https://serverlessland.com/workflows)


Suggested change

To create a full Step Functions workflow with the pattern created, you can find out example workflows at Step Functions Workflow: [serverlessland.com/workflows](https://serverlessland.com/workflows)

To expand the Step Functions workflow that the pattern created, you can find out example workflows at Step Functions Workflow: [serverlessland.com/workflows](https://serverlessland.com/workflows)

Sorry, updated.

bfreiberg · 2024-07-08T13:17:12Z

s3-sqs-lambda-terraform/main.tf

+  function_name = "s3-sqs-lambda-tf-LambdaFunction"
+  role          = aws_iam_role.MyHandlerFunction-Role.arn
+  handler       = "app.handler"
+  runtime       = "nodejs16.x"


The Nodejs v16 runtime is deprecated https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Please use the latest Nodejs runtime

Upgrading it

s3-sqs-lambda-terraform/main.tf

bfreiberg · 2024-07-08T13:20:16Z

s3-sqs-lambda-terraform/src/app.mjs

+    console.log('value2 =', event.key2);
+    console.log('value3 =', event.key3);
+    return event.key1;  // Echo back the first key value
+    // throw new Error('Something went wrong');


remove unnecessary line

I Agree, removing it

enmata · 2024-07-10T09:05:21Z

Code updated with agreed changes

enmata · 2024-07-12T12:55:42Z

Sorry, I forget to add comments changes. Now its updated.

bfreiberg

Looks good, just one typo left. However, you are missing the example-pattern.json.

Use the model template located at https://github.com/aws-samples/serverless-patterns/tree/main/_pattern-model to set up a README, template and any associated code.

THIS PROCESS HAS BEEN SIMPLIFIED. All the information below must be provided in the "example-pattern.json" file cloned from the model **

The above text is taken from the new pattern template.

bfreiberg · 2024-07-16T13:21:39Z

s3-sqs-lambda-terraform/README.md

@@ -0,0 +1,81 @@
+# Amazon S3 to Amaozn SQS queue to AWS Lambda


Suggested change

# Amazon S3 to Amaozn SQS queue to AWS Lambda

# Amazon S3 to Amazon SQS queue to AWS Lambda

Typo fixed, thanks.

example-pattern.json file added as an attachment on initial post on these PR. Do you want me do add it on the commit?

bfreiberg · 2024-07-26T14:51:51Z

Thanks for the update. To be clear, the example-pattern.json file must be added to the PR and filled out by you with corresponding values, e.g. language, level, relevant links etc.
See here for an example from a different pattern.

enmata · 2024-07-29T07:16:29Z

Added example-pattern.json

bfreiberg · 2024-08-13T10:47:03Z

s3-sqs-lambda-terraform/example-pattern.json

+{
+  "title": "S3 to Step Functions using EventBridge",
+  "description": "How to create an EventBridge rule with S3 as the event source and Step Functions as target.",
+  "language": "nodejs",


Suggested change

"language": "nodejs",

"language": "Node.js",

ok, changed

bfreiberg · 2024-08-13T10:48:11Z

s3-sqs-lambda-terraform/example-pattern.json

@@ -0,0 +1,61 @@
+{
+  "title": "S3 to Step Functions using EventBridge",


Please use the same title as in the README

Sorry bout the confusion, updated.

bfreiberg · 2024-08-13T10:48:39Z

s3-sqs-lambda-terraform/example-pattern.json

@@ -0,0 +1,61 @@
+{
+  "title": "S3 to Step Functions using EventBridge",
+  "description": "How to create an EventBridge rule with S3 as the event source and Step Functions as target.",


Please update the description to match the contents

Sorry bout the confusion, updated.

bfreiberg · 2024-08-13T10:49:01Z

s3-sqs-lambda-terraform/example-pattern.json

+  "level": "200",
+  "framework": "Terraform",
+  "introBox": {
+    "headline": "How to create an EventBridge rule with S3 as the event source and Step Functions as target.",


Please update to match the actual pattern

Sorry bout the confusion, updated.

This still seems to be unresolved

bfreiberg · 2024-08-13T10:49:11Z

s3-sqs-lambda-terraform/example-pattern.json

+      "This sample project demonstrates how you can trigger an execution in Step Functions state machine when an object is created in an S3 bucket.",
+      "When you uploads an object to the newly created S3 bucket, this will send an `Object Created` event to EventBridge, based on the EventBridge rule, the state machine is executed.",
+      "This pattern deploys one Step Functions state machine, one S3 bucket, one EventBridge rule."


Sorry bout the confusion, updated.

bfreiberg · 2024-08-13T10:49:42Z

s3-sqs-lambda-terraform/example-pattern.json

+        "text": "AWS S3 Event Notifications with EventBridge",
+        "link": "https://aws.amazon.com/blogs/aws/new-use-amazon-s3-event-notifications-with-amazon-eventbridge"
+      },
+      {
+        "text": "Using EventBridge with S3",
+        "link": "https://docs.aws.amazon.com/AmazonS3/latest/userguide/EventBridge.html"


Please update with relevant links

bfreiberg · 2024-08-13T10:50:06Z

s3-sqs-lambda-terraform/example-pattern.json

+  },
+  "cleanup": {
+    "text": [
+      "terraform destroy"


Suggested change

"terraform destroy"

"<code>terraform destroy</code>"

Good point, all code commands updated

bfreiberg · 2024-08-13T10:50:16Z

s3-sqs-lambda-terraform/example-pattern.json

+      "name": "Oriol Matavacas",
+      "image": "https://togithub.s3.eu-west-1.amazonaws.com/Oriol.jpg",
+      "bio": "Oriol Matavacas is a Sr. Solutions Architect at AWS based in Barcelona. Oriol primarily supporting customers on the journey to the Cloud. He enjoys building new solutions with scalability, availability and easy to maintain by using serverless.",
+      "linkedin": "https://www.linkedin.com/in/oriol-matavacas-rodriguez-b165868a",


Suggested change

"linkedin": "https://www.linkedin.com/in/oriol-matavacas-rodriguez-b165868a",

"linkedin": "oriol-matavacas-rodriguez-b165868a",

enmata · 2024-08-16T07:55:36Z

Thanks for the comments and sorry bout the confusion. Now its updated.

bfreiberg · 2024-08-21T10:01:09Z

s3-sqs-lambda-terraform/example-pattern.json

+  "level": "200",
+  "framework": "Terraform",
+  "introBox": {
+    "headline": "How to create an EventBridge rule with S3 as the event source and Step Functions as target.",


This still seems to be unresolved

bfreiberg · 2024-08-21T10:02:01Z

s3-sqs-lambda-terraform/example-pattern.json

+    "text": [
+      "The terraform manifest deploys a Lambda function, an SQS queue, one S3 bucket and the IAM resources required to run the application.",
+      "An SQS queue consumes ObjectCreated events from an Amazon S3 bucket if the file has .jpg extension. The SQS triggers a Lambda function.",
+      "The Lambda app acts as a boilerplate code.",


What do you mean by this?

Explanation updated

bfreiberg · 2024-08-21T10:02:24Z

s3-sqs-lambda-terraform/example-pattern.json

+        "text": "S3-to-Lambda serverless applications",
+        "link": "https://docs.aws.amazon.com/AmazonS3/latest/userguide/EventBridge.html"


Link and text don't seem to match

Please note that this is still resolved

bfreiberg · 2024-08-21T10:02:53Z

s3-sqs-lambda-terraform/example-pattern.json

+    "bullets": [
+      {
+        "text": "Building resilient serverless patterns by combining messaging services",
+        "link": "https://github.com/aws-samples/s3-to-lambda-patterns"


Link is outdated and doesn't really match the text

Thanks for the heads up, reference updated

enmata · 2024-08-21T12:18:12Z

Thanks for the comments, now updated its updated again.

enmata · 2024-08-26T16:48:44Z

Changes applied. Please check when you have a moment.

bfreiberg · 2024-09-10T18:13:37Z

s3-sqs-lambda-terraform/example-pattern.json

@@ -0,0 +1,61 @@
+{
+  "title": "AWS Amazon S3 Lambda with SQS queue",


Suggested change

"title": "AWS Amazon S3 Lambda with SQS queue",

"title": "Amazon S3 to AWS Lambda with Amazon SQS queue",

Thanks, changes applied

bfreiberg · 2024-09-10T18:14:40Z

s3-sqs-lambda-terraform/example-pattern.json

@@ -0,0 +1,61 @@
+{
+  "title": "AWS Amazon S3 Lambda with SQS queue",
+  "description": "Create a Lambda function triggered for every jpg image file stored to S3 via SQS.",


Suggested change

"description": "Create a Lambda function triggered for every jpg image file stored to S3 via SQS.",

"description": "Create a Lambda function that is triggered for every jpg image file uploaded to S3 via an SQS queue.",

Thanks, changes applied

bfreiberg · 2024-09-10T18:16:30Z

s3-sqs-lambda-terraform/example-pattern.json

+{
+  "title": "AWS Amazon S3 Lambda with SQS queue",
+  "description": "Create a Lambda function triggered for every jpg image file stored to S3 via SQS.",
+  "language": "node.js",


Suggested change

"language": "node.js",

"language": "Node.js",

Uppercase now

bfreiberg · 2024-09-10T18:17:12Z

s3-sqs-lambda-terraform/example-pattern.json

+  "level": "200",
+  "framework": "Terraform",
+  "introBox": {
+    "headline": "Create a Lambda function triggered for every jpg image file stored to S3 via SQS",


The headline needs to stay below 75 characters, please reword

Compressed and resumed now. Please check

bfreiberg · 2024-09-10T18:17:54Z

s3-sqs-lambda-terraform/example-pattern.json

+        "link": "https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-configure-lambda-function-trigger.html",
+      },
+      {
+        "text": "Amazon Simple Storage Service (S3) -> User Guide -> Using EventBridge",


How does EventBridge relate to the rest of the pattern? It isn't mentioned anywhere else

Right and sorry for that. Reference deleted.

bfreiberg · 2024-09-10T18:18:22Z

s3-sqs-lambda-terraform/example-pattern.json

+      "<code>terraform init</code>",
+      "<code>terraform apply</code>"


tags can be removed here as they are automatically added to the deploy field

enmata · 2024-09-18T14:25:19Z

Thanks for the comments, changes applied. Please, could you review again?

bfreiberg · 2024-11-20T09:42:18Z

Looks good, thanks for your contribution. Your pattern will be merged to Serverlessland.com soon

Add s3-sqs-lambda-terraform pattern

8778254

julianwood assigned bfreiberg and julianwood Jul 8, 2024

enmata mentioned this pull request Jul 8, 2024

s3-sqs-lambda-terraform pattern submission #2361

Closed

bfreiberg closed this Jul 8, 2024

bfreiberg reopened this Jul 8, 2024

bfreiberg reviewed Jul 8, 2024

View reviewed changes

Adding changes after PR comments

8550a91

Adding comments changes after PR discussion

ae5feec

bfreiberg reviewed Jul 16, 2024

View reviewed changes

Fixing typos on README

cefa38e

Adding example-pattern.json

4307b2a

bfreiberg reviewed Aug 13, 2024

View reviewed changes

Fixing example-pattern.json description and bullets with PR comments

8d6cff0

bfreiberg reviewed Aug 21, 2024

View reviewed changes

Updating example-pattern.json as per PR comments

3d4a499

Updating example-pattern.json as per PR comments

3ab54f6

bfreiberg requested changes Sep 10, 2024

View reviewed changes

Updating example-pattern.json as per PR comments

4e5ed7c

bfreiberg added 2 commits November 20, 2024 10:37

Add final pattern file

cc4df54

Update example-pattern.json

8a32f8a

bfreiberg approved these changes Nov 20, 2024

View reviewed changes

bfreiberg added the Patterns Guardian approved label Nov 20, 2024

julianwood merged commit f8d4f06 into aws-samples:main Dec 10, 2024

	# AWS Amazon S3 Lambda with SQS queue
	# Amazon S3 to Amaozn SQS queue to AWS Lambda

		@@ -0,0 +1,81 @@
		# AWS Amazon S3 Lambda with SQS queue

		The terraform manifest deploys a Lambda function, an SQS queue, one S3 buckets and the IAM resources required to run the application. Create a Lambda function that is triggered on every new jpg image file stored on s3 Bucket using SQS as a notification target. The Lambda app acts as a Boilerplate code.

	The terraform manifest deploys a Lambda function, an SQS queue, one S3 buckets and the IAM resources required to run the application. Create a Lambda function that is triggered on every new jpg image file stored on s3 Bucket using SQS as a notification target. The Lambda app acts as a Boilerplate code.
	The Terraform code deploys an AWS Lambda function, an Amazon SQS queue, one AWS S3 buckets and the AWS IAM resources required to run the application. The created Lambda function is triggered on every new `.jpg` image file uploaded to the S3 bucket using an SQS queue as a notification target. The Lambda function code contains only contains minimal code for demo purposes.

	* If the object is a .jpg the code, a Lambda that is triggered using SQS as a notification target.
	* If the object is a .jpg file, the Lambda function is triggered using SQS as a notification target.


		## Testing

		Run the following S3 CLI command to upload an image to the S3 bucket. Note, you must edit the {SourceBucketName} placeholder with the name of the source S3 Bucket. This is provided in the stack outputs.

	Run the following S3 CLI command to upload an image to the S3 bucket. Note, you must edit the {SourceBucketName} placeholder with the name of the source S3 Bucket. This is provided in the stack outputs.
	Run the following AWS CLI command to upload an image to the S3 bucket. Note, you must edit the {SourceBucketName} placeholder with the name of the source S3 bucket. This is provided in the stack outputs.


		## Documentations and next step

		To create a full Step Functions workflow with the pattern created, you can find out example workflows at Step Functions Workflow: [serverlessland.com/workflows](https://serverlessland.com/workflows)

	To create a full Step Functions workflow with the pattern created, you can find out example workflows at Step Functions Workflow: [serverlessland.com/workflows](https://serverlessland.com/workflows)
	To expand the Step Functions workflow that the pattern created, you can find out example workflows at Step Functions Workflow: [serverlessland.com/workflows](https://serverlessland.com/workflows)

	# Amazon S3 to Amaozn SQS queue to AWS Lambda
	# Amazon S3 to Amazon SQS queue to AWS Lambda

		@@ -0,0 +1,61 @@
		{
		"title": "S3 to Step Functions using EventBridge",

	"linkedin": "https://www.linkedin.com/in/oriol-matavacas-rodriguez-b165868a",
	"linkedin": "oriol-matavacas-rodriguez-b165868a",

		"text": "S3-to-Lambda serverless applications",
		"link": "https://docs.aws.amazon.com/AmazonS3/latest/userguide/EventBridge.html"

		@@ -0,0 +1,61 @@
		{
		"title": "AWS Amazon S3 Lambda with SQS queue",

	"title": "AWS Amazon S3 Lambda with SQS queue",
	"title": "Amazon S3 to AWS Lambda with Amazon SQS queue",

	"description": "Create a Lambda function triggered for every jpg image file stored to S3 via SQS.",
	"description": "Create a Lambda function that is triggered for every jpg image file uploaded to S3 via an SQS queue.",

		"<code>terraform init</code>",
		"<code>terraform apply</code>"

Add s3-sqs-lambda-terraform pattern #2360

Add s3-sqs-lambda-terraform pattern #2360

Uh oh!

Conversation

enmata commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bfreiberg commented Jul 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enmata commented Jul 10, 2024

Uh oh!

enmata commented Jul 12, 2024

Uh oh!

bfreiberg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bfreiberg commented Jul 26, 2024

Uh oh!

enmata commented Jul 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

enmata commented Jul 8, 2024 •

edited

Loading