Support AZs list #8
Conversation
…nce types across multiple zones
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 89.44% 89.60% +0.15%
==========================================
Files 7 7
Lines 758 779 +21
==========================================
+ Hits 678 698 +20
Misses 53 53
- Partials 27 28 +1
Continue to review full report at Codecov.
|
pkg/selector/selector.go
Outdated
| if isZoneID, _ := regexp.MatchString(zoneIDRegex, zone); isZoneID { | ||
| instanceTypeOfferingsInput.SetLocationType(zoneIDLocationType) | ||
| } else if isZoneName, _ := regexp.MatchString(zoneNameRegex, zone); isZoneName { | ||
| instanceTypeOfferingsInput.SetLocationType(zoneNameLocationType) | ||
| } else if isRegion, _ := regexp.MatchString(regionNameRegex, zone); isRegion { | ||
| instanceTypeOfferingsInput.SetLocationType(regionNameLocationType) | ||
| } else { | ||
| return nil, fmt.Errorf("The location passed in (%s) is not a valid zone-id, zone-name, or region name", zone) | ||
| } |
There was a problem hiding this comment.
could be nicer to pull this out to a helper func
pkg/selector/selector.go
Outdated
| if _, ok := availableInstanceTypes[*instanceType.InstanceType]; !ok { | ||
| availableInstanceTypes[*instanceType.InstanceType] = 1 | ||
| } else { | ||
| i, _ := availableInstanceTypes[*instanceType.InstanceType] | ||
| availableInstanceTypes[*instanceType.InstanceType] = i + 1 | ||
| } |
There was a problem hiding this comment.
I feel like this isn't the cleanest way to write this since you're splitting i, ok := availableInstanceTypes[*instanceType.InstanceType] into two parts, but my brain isn't working right now to come up with a nicer implementation
There was a problem hiding this comment.
ha yeah, you're right! I fixed it since the i is still in scope of the if... :)
| h.Ok(t, err) | ||
| h.Assert(t, len(results) == 3, "c4.large should return 3 similar instance types") | ||
| } | ||
|
|
There was a problem hiding this comment.
what happens when there's a mix of good + bad AZs?
There was a problem hiding this comment.
added tests to ensure these cases work 🕺
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.