EFS functional testing #2247
Merged
EFS functional testing #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharanyad
reviewed
Oct 24, 2019
| t.Skip("TEST_DISABLE_EXECUTION_ROLE was set to true") | ||
| } | ||
|
|
||
| if IsCNPartition() { |
There was a problem hiding this comment.
this URL will not work in the CN partition: addr=FILESYSTEM_ID.efs.TEST_REGION.amazonaws.com, there is currently a TODO in the feature branch (and design doc) to deal with this in EFSVolumeConfiguration (see https://github.com/aws/amazon-ecs-agent/pull/2234/files#diff-a617e6edf02b5af84b984ccb06ce315fR547)
sparrc
force-pushed
the
efs-volumes-func-tests
branch
3 times, most recently
from
7a40418
to
cf2e1da
Compare
adnxn
reviewed
Oct 25, 2019
sparrc
force-pushed
the
efs-volumes-func-tests
branch
from
cf2e1da
to
88e5d8c
Compare
sharanyad
reviewed
Oct 28, 2019
| if aerr, ok := err.(awserr.Error); ok { | ||
| switch aerr.Code() { | ||
| case efs.ErrCodeFileSystemAlreadyExists: | ||
| t.Logf("EFS filesystem already exists") |
There was a problem hiding this comment.
Do we expect to reuse the same file system created once for the tests? I don't see any cleanup logic.
There was a problem hiding this comment.
yes, we expect to reuse the filesystem, that's why we check for ErrCodeFileSystemAlreadyExists (filesystem already exists) and ErrCodeMountTargetConflict (mount target already exists)
The main reason for this is speed, and the EFS api makes it easy with the CreationToken: https://docs.aws.amazon.com/efs/latest/ug/API_CreateFileSystem.html#API_CreateFileSystem_RequestSyntax
sharanyad
approved these changes
Oct 28, 2019
petderek
reviewed
Oct 28, 2019
fenxiong
reviewed
Oct 28, 2019
petderek
reviewed
Oct 28, 2019
petderek
reviewed
Oct 28, 2019
| // getSubnetID gets the subnet id for the instance from ec2 instance metadata | ||
| func getSubnetID() (string, error) { | ||
| // GetSubnetID gets the subnet id for the instance from ec2 instance metadata | ||
| func GetSubnetID() (string, error) { |
yumex93
approved these changes
Oct 29, 2019
|
LGTM. Don't forget to squash your commits before merging to dev. |
sparrc
added a commit
that referenced
this pull request
Nov 5, 2019
* Add efs client to Gopkg.* * Add efs client to vendor directory * EFS functional test * Reuse EFS filesystem and mount target(s) * review fixups * more code review fixups
sparrc
added a commit
that referenced
this pull request
Dec 4, 2019
* Add efs client to Gopkg.* * Add efs client to vendor directory * EFS functional test * Reuse EFS filesystem and mount target(s) * review fixups * more code review fixups
sparrc
added a commit
that referenced
this pull request
Dec 5, 2019
* Add efs client to Gopkg.* * Add efs client to vendor directory * EFS functional test * Reuse EFS filesystem and mount target(s) * review fixups * more code review fixups
sparrc
added a commit
that referenced
this pull request
Dec 6, 2019
* Added EFSVolumeConfiguration (#2234) * Added EFSVolumeConfiguration models * Translate EFS volumes from ACS to Docker volume type * fix gocyclo failure * code review comments * remove readonly config * remove readonly options from code * code review comments * code review * naming is hard * Add efs capability (#2248) * EFS functional testing (#2247) * Add efs client to Gopkg.* * Add efs client to vendor directory * EFS functional test * Reuse EFS filesystem and mount target(s) * review fixups * more code review fixups * EFSVolumeConfiguration -> efsVolumeConfiguration (#2254) * EFSVolumeConfiguration -> efsVolumeConfiguration * Fix FileSystemId and write json marshalling unit tests * unit test PostUnmarshalTask efsVolumeConfiguration behavior * windows unit test fix * Update ECS client and task defs (#2256) * add memoryUnbounded to task volume marshal unit tests * rebase mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a functional test testing writing/reading from EFS volumes mounted via Docker's NFS integration.
Implementation details
In this test we will setup an EFS volume with mount target. We will then mount this into two tasks: first a task that writes to the EFS volume, then a task that reads from the EFS volume.
Both tasks exit with code
42if they are successful, so we check for this exit code to verify that the test passed.Currently this is implemented using the existing
dockerVolumeConfigurationmodel. When the feature is ready this will be changed to theEFSVolumeConfigurationmodel.Description for the changelog
EFS volume configuration functional testing
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.