EFSVolumeConfiguration -> efsVolumeConfiguration #2254
Conversation
|
Can you build a test agent image, test against gamma endpoint and include the result in the pr description? Just to double check. |
agent/acs/model/ecsacs/api.go
Outdated
| @@ -413,7 +413,7 @@ func (s ECRAuthData) GoString() string { | |||
| return s.String() | |||
| } | |||
|
|
|||
| type EFSVolumeConfiguration struct { | |||
| type EfsVolumeConfiguration struct { | |||
There was a problem hiding this comment.
Did you use gogenerate to generate the api.go file or the command included in the generate.go file? That should be the right way to do it. And if you did that, the struct name should still beEFSVolumeConfiguration.
sure....although it's nothing too exciting: % /usr/local/go/bin/go test -count=1 -v -cover -tags unit -timeout=60s -run=arshalTaskVolumes ./agent/api/task/... |
* EFSVolumeConfiguration -> efsVolumeConfiguration * Fix FileSystemId and write json marshalling unit tests * unit test PostUnmarshalTask efsVolumeConfiguration behavior * windows unit test fix
* EFSVolumeConfiguration -> efsVolumeConfiguration * Fix FileSystemId and write json marshalling unit tests * unit test PostUnmarshalTask efsVolumeConfiguration behavior * windows unit test fix
* EFSVolumeConfiguration -> efsVolumeConfiguration * Fix FileSystemId and write json marshalling unit tests * unit test PostUnmarshalTask efsVolumeConfiguration behavior * windows unit test fix
* Added EFSVolumeConfiguration (#2234) * Added EFSVolumeConfiguration models * Translate EFS volumes from ACS to Docker volume type * fix gocyclo failure * code review comments * remove readonly config * remove readonly options from code * code review comments * code review * naming is hard * Add efs capability (#2248) * EFS functional testing (#2247) * Add efs client to Gopkg.* * Add efs client to vendor directory * EFS functional test * Reuse EFS filesystem and mount target(s) * review fixups * more code review fixups * EFSVolumeConfiguration -> efsVolumeConfiguration (#2254) * EFSVolumeConfiguration -> efsVolumeConfiguration * Fix FileSystemId and write json marshalling unit tests * unit test PostUnmarshalTask efsVolumeConfiguration behavior * windows unit test fix * Update ECS client and task defs (#2256) * add memoryUnbounded to task volume marshal unit tests * rebase mistake
Summary
For API consistency this structure has been named efsVolumeConfiguration instead of the originally-planned EFSVolumeConfiguration
Implementation details
Testing
New tests cover the changes: no
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.