-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retries to get ec2 instance-id #2861
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenxiong
reviewed
Apr 30, 2021
mythri-garaga
force-pushed
the
retry-getInstanceId
branch
from
April 30, 2021 20:11
3f3ed62
to
4bd05bf
Compare
sharanyad
reviewed
Apr 30, 2021
sharanyad
reviewed
Apr 30, 2021
mythri-garaga
force-pushed
the
retry-getInstanceId
branch
from
May 3, 2021 16:46
4bd05bf
to
93359a2
Compare
sharanyad
previously approved these changes
May 3, 2021
sparrc
previously approved these changes
May 3, 2021
Realmonia
previously approved these changes
May 3, 2021
angelcar
reviewed
May 3, 2021
mythri-garaga
dismissed stale reviews from Realmonia, sparrc, and sharanyad
via
May 3, 2021 20:05
d97eccb
mythri-garaga
force-pushed
the
retry-getInstanceId
branch
from
May 3, 2021 20:05
93359a2
to
d97eccb
Compare
angelcar
approved these changes
May 4, 2021
sharanyad
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently when agent fails to get instance id from EC2 metadata service, agent overwrites InstanceID in state file with ''. This PR includes changes to call instance metadata service at least 3 times to get instance id before returning an empty string.
Implementation details
Testing
make test
passesNew tests cover the changes: yes
Description for the changelog
Enhancement - Add retries while retrieving instance-id using EC2 Instance metadata service api
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.