al2gpu: Remove epel repo after installing dkms and nvidia open modules #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fierlion
reviewed
Jan 18, 2024
| sudo yum-config-manager --disable epel | ||
| sudo rm /etc/yum.repos.d/epel.repo | ||
| sudo rm /etc/yum.repos.d/epel-testing.repo | ||
| sudo amazon-linux-extras disable epel |
There was a problem hiding this comment.
good catch -- I had to go validate this myself to see that the epel topic was auto-enabled by the install.
24 epel=latest enabled [ =7.11 =stable ]
It was.
fierlion
approved these changes
Jan 18, 2024
Yiyuanzzz
approved these changes
Jan 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After installing dkms and nvidia open modules, remove and cleanup the epel repo.
The reason for this is that the epel repo is a public fedora repo. The URLs of this repo require access to the open internet. Customers using isolated subnets will not have internet access so all package updates and installs will fail when yum tries talking to the epel repo.
Removing it ensures that the AMI by default only points to internal Amazon Linux repos which are accessible in isolated subnets.
Testing
al2gpu AMI built, ran /var/lib/ecs/scripts/install-nvidia-open-kmod.sh script
New tests cover the changes:
Description for the changelog
Bugfix: Fix al2gpu AMI package installs and updates when running in isolated subnets
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.