-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create services with a load balancer #21
Comments
+1 |
2 similar comments
+1 |
+1 |
PSA: use the subscribe button on the right to indicate "+1". |
+1 |
+1 |
I wrote this in the meantime: https://github.com/lox/ecsy |
Has there been any traction on this? |
+1 |
5 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
@sunghoaraipark @vincetse There is a built in voting system now using reactions. it's better to add a thumbs up reaction to the first comment |
Hi, do we have any idea of an ETA of when / if this might be available? |
As there has been no updates on this, I've been using Cloudformation for few months now for managing ECS. After recent updates, it supports all paramaters I need. Might work for some one else too. |
+1 |
1 similar comment
+1 |
@kaihendry I am using following script to do what @geowa4 mentioned in the description
and my
|
+1 |
@LeandroCR please use the built-in reaction system instead of a "+1" comment. GitHub finally implemented it (and you can sort issues by them) so let's use them! 😄 |
+1 |
Thanks for the starting point @ankitcha I maintain a set of scripts to setup the load balancer with ECS here: https://github.com/kaihendry/count I really really hope ecs-cli gets some love and fixes this standard use case. |
New to ecs, dissapointed to see this use case isn't supported OOTB. Thanks for sharing your workaround @ankitcha, I'm just wondering, if you subsequently scale out/in your containers, will ELB automatically update to reflect the changes? |
Excuse me, I just neglected to include the I'm not sure what you mean by "when the service is not created with the LB". I created the ELB and target groups from within the console and specified the ARN that I created in the command above. Do I need to do something other than just run the |
Oh, huh. I was wondering why it wasn't updating when I updated the service definition, but it seems like there's no way to update the load balancer a service uses? It looks like it's missing from |
Ahh, I see. The behavior is expected, see documentation:
To avoid confusions here, we should add validations on cli when the service already exists. |
Yeah, this was really confusing and spent about an hour on it last night. An error message would be nice. :) Cool if I submit a PR to this effect? |
Sorry for the confusion, we definitely need better error handling here. I will create a new issue to follow up on this :) Thanks! |
@yinshiua, any idea whether this will be created using Cloudformation or via API? |
@shatil Currently, we only support using existing ELB in Create Service. We are planning on supporting the ELB creation possibly using the CloudFormation, but I do not have an ETA yet. |
Since I struggle with this every week, I thought I would share the script I use to deploy services with. Prerequisites:
So I wish there was something to quickly create the ALBs, not easy thanks to a certificate dance. And not sure what or where the role was supposed to be created. I do it manually on new accounts for want of a better way. |
@kaihendry I get a 404 on your link |
I see that the latest docs have already been updated with support for adding a load balancer to a service -- https://docs.aws.amazon.com/AmazonECS/latest/developerguide/cmd-ecs-cli-compose-service.html Any idea when this version will be released? Are there instructions with how to build from source? |
@SoManyHs Is what @jasonrhaas says true? Or is the best way still to generate tasks using |
@jordantomax Yes, what @jasonrhaas mentions is correct. The docs link has changed: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/cmd-ecs-cli-compose-service-up.html Here's an example of creating a service with an ALB (target group and ALB must already exist):
We're going to close this issue; for any new requests, please open a new issue and we'll respond accordingly. Thanks everyone for the feedback, we use this to help prioritize features for the ECS CLI! |
@jordantomax If you wanted to create a load balancer in the same workflow as creating an ECS service (rather than specifying one that was created separately), you might be interested in checking out the CDK! https://awslabs.github.io/aws-cdk/refs/_aws-cdk_aws-ecs.html#include-a-load-balancer |
@PettitWesley I'm happy to create a new issue if you think that's the best thing to do. However, the command you listed still isn't working for me :(. The docs you sent are for |
@jordantomax Yeah, please create a new issue if you want the ECS CLI to support creating a load balancer, as opposed to merely creating an ECS Service with an existing load balancer. Sorry about the docs link- I've edited it to include the link for Also, for your problem with the command- can you create a new issue and show the exact command that you ran, etc? That would help us determine your problem. Right now, our best guess is that you might not be using the correct ARN with the target group flag- that's something we've seen before. |
@PettitWesley Got it. Actually looks like my problem was that I was specifying the flag on the |
Will this parameter be added to the ecs-params.yml? |
@pecigonzalo The parameter can definitely be added to the ECS Params yaml file! Can you create an issue so that we can track that request? Also, we always welcome pull requests, especially for small improvements like this :) |
Sure things, I was unsure if it was support and just not documented. Will
open an issue and try to PR the fix.
…On Thu, Jan 17, 2019, 7:20 PM Wesley Pettit ***@***.*** wrote:
@pecigonzalo <https://github.com/pecigonzalo> The parameter can
definitely be added to the ECS Params yaml file! Can you create an issue so
that we can track that request? Also, we always welcome pull requests,
especially for small improvements like this :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJcviez4fI3Ogg9eZiXNd1xMmwtDU1FMks5vEL7egaJpZM4GN2XE>
.
|
@pecigonzalo Awesome! |
ecs-cli has been wonderful. For me, it's missing the ability to create services with load balancers. As a workaround, I define tasks with ecs-cli and use aws-cli (http://docs.aws.amazon.com/cli/latest/reference/ecs/create-service.html) to create the service with the load balancer.
The text was updated successfully, but these errors were encountered: