This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
update to latest aws-sdk-go #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 2, 2020
fierlion
force-pushed
the
update_awssdkgo
branch
from
cca817a to
9bacd7f
Compare
angelcar
approved these changes
Dec 2, 2020
mssrivas
approved these changes
Dec 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
related ecs-agent PR: aws/amazon-ecs-agent#2707
This will update the aws-sdk-go to 1.35.37 (the latest version as of this PR).
Implementation details
make get-depto install dep on my instance. (I also updated the Makefile to add the get-dep target.)I then updated the gopkg.toml and ran
dep ensureto pull in this latest version of aws-sdk-go.then
make gogenerateto re-generate mocks.Testing
I ran
make testandmake static-check(which initially failed due to go vet finding logger config distasteful)tested build with
makeNew tests cover the changes: no
Description for the changelog
Update aws-sdk-go to 1.35.37
Licensing
This contribution is under the terms of the Apache 2.0 License: