Skip to content

fix: running code in windows environment #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Conversation

mzvrzg
Copy link
Contributor

@mzvrzg mzvrzg commented Mar 31, 2021

I was getting file not found error, as it turned out the path to the redshift-ca-bundle.crt was incorrectly constructed on MS Windows platform

Description

check to see the OS name to construct path accordingly

Motivation and Context

I kept running into file not found error when connecting to database, and it turned out path to redshift-ca-bundle.crt wasn't correct in MS Windows environment

Testing

Screenshots (if appropriate)

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [ x ] Local run of python3 setup.py succeeds
  • [ x ] My code follows the code style of this project
  • [ x ] I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I was getting file not found error, as it turned out the path to the redshift-ca-bundle.crt was incorrectly constructed on MS Windows platform
@Brooke-white
Copy link
Contributor

Hey @mzvrzg , Thanks for posting this PR. The team will review this internally and get back to you shortly with feedback

@Brooke-white
Copy link
Contributor

Hey @mzvrzg , Thank you for identifying and resolving this issue!

I have verified the existing issue with the ca cert path on Windows, and that this PR resolves it.

The team would like to merge this PR, but would like to ask you to modify your commit message to comply with conventional commit specification to help maintain the readability of the repository's changelog

@mzvrzg mzvrzg changed the title running code in windows environment doc: running code in windows environment Apr 1, 2021
@Brooke-white Brooke-white changed the title doc: running code in windows environment fix: running code in windows environment Apr 2, 2021
@Brooke-white Brooke-white merged commit 9cca6a7 into aws:master Apr 2, 2021
@Brooke-white
Copy link
Contributor

Brooke-white commented Apr 2, 2021

thank you for your contribution to redshift_connector! :) We anticipate your PR will be made available in our next release, which is scheduled for April 19th.

@mzvrzg mzvrzg deleted the patch-1 branch April 2, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants