fix: errors thrown in plugin construction may appear as a missing dependency #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Oct 21, 2024
common/lib/authentication/aws_secrets_manager_plugin_factory.ts
Outdated
Show resolved
Hide resolved
joyc-bq
reviewed
Oct 22, 2024
karenc-bq
approved these changes
Oct 23, 2024
sophia-bq
force-pushed
the
pluginConstruction
branch
from
a27d0ac to
8176ba9
Compare
…endency Add error messages to en.json
sophia-bq
force-pushed
the
pluginConstruction
branch
from
8176ba9 to
715a78d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix: errors thrown in plugin construction may appear as a missing dependency
Description
Any errors associated with importing and constructing the plugin are swallowed by each plugin's plugin factory which logs the error and then returns
The plugin could not be imported. Please ensure the required dependencies have been installed. Plugin: '<plugin-name>'This error was thrown upon attempts to construct the AwsSecretsManagerPlugin without a secretId, even though the error caught correctly identified the issue. The AwsSecretsManagerPlugin is the only plugin currently that has a required property (
secretId) that is not handled before construction. When any other required property is missing, an error is thrown before reaching the plugin factory.Additionally, manipulation of the host property was attempted without first checking if it was provided, this led to confusing error messages.
Changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.