fix: separate plugin chain cache based on whether a plugin needs to be skipped or not #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-congo
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normally we only need to skip a plugin during the execute pipeline when we are already in the pipeline and don't want to call the same plugin again.
For instance, when establishing the initial connection in Limitless Plugin it might enter a branch where the plugin calls
this._plugin_service.connect. This eventually ends up inPluginManger._execute_with_subscribed_plugins. The wrapper will check if a pipeline has already been created and reuse that. This is problematic if the cached pipeline contains the plugin we need to skip.This change stores regular pipelines and "skipped" pipelines with different cache keys to avoid this issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.