Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ecs: EcsOptimizedImage does not support Inferentia #28198

Closed
2 tasks
mostafafarzaneh opened this issue Nov 30, 2023 · 2 comments · Fixed by #28819
Closed
2 tasks

aws-ecs: EcsOptimizedImage does not support Inferentia #28198

mostafafarzaneh opened this issue Nov 30, 2023 · 2 comments · Fixed by #28819
Assignees
@gracelu0
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mostafafarzaneh
Copy link

Describe the feature

This issue has been asked here before

Here is explained how to get the ECS optimized Amazon Linux 2 (Neuron) AMI. But I can't find how to use it in ecs.AsgCapacityProvider .

Use Case

Using AWS Inferentia in AWS ECS.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.105.0 (build 04cb52d)

Environment details (OS name and version, etc.)

Ubuntu 20.04.2 LTS
@mostafafarzaneh mostafafarzaneh added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 30, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Nov 30, 2023
@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Dec 1, 2023
@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 18, 2023
@khushail
Copy link
Contributor

Thanks @mostafafarzaneh for submitting this request. Looks like, we We need to add it in the enum here and handle it correct to return correct AMI. Contributions from the community are welcome for this request.

@gracelu0 gracelu0 self-assigned this Jan 16, 2024
@gracelu0 gracelu0 mentioned this issue Jan 22, 2024
Merged
@mergify mergify bot closed this as completed in #28819 Jan 23, 2024
mergify bot pushed a commit that referenced this issue Jan 23, 2024
@gracelu0
feat(ecs): add neuron to ecs AMI hardware type (#28819)
ef1d64e 
ECS now supports Amazon ECS optimized Amazon Linux 2 (Neuron) AMI variant for Amazon EC2 Inf1, Trn1 or Inf2 instances (see [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html)). It helps make running machine learning inference workloads easier on Amazon ECS.

Add a new enum value, `NEURON` to `AMIHardwareType` to allow users to specify this AMI when setting up their ECS cluster. Add code to retrieve SSM parameter name for this AMI variant (see SSM parameter format for ECS-optimized AMI [here](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/retrieve-ecs-optimized_AMI.html#ecs-optimized-ami-parameter-format)).

Closes #28198 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gracelu0 gracelu0

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): add neuron to ecs AMI hardware type gracelu0/aws-cdk
3 participants
@gracelu0 @mostafafarzaneh @khushail