feat(core): make the CfnParameter class mutable #9365
Conversation
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
…::And, Fn::Not, and Fn::Or, including unit tests.
…ntrinsic functions
…ied the return type of transform to IResolvable, and updated transform docs
skinny85
changed the title
| } | ||
|
|
||
| /** | ||
| * Indicates if this parameter is configured with "NoEcho" enabled. | ||
| */ | ||
| public get noEcho(): boolean { | ||
| return !!this.props.noEcho; | ||
| public get noEcho(): boolean | undefined { |
There was a problem hiding this comment.
Just to be clear, I meant only the setter. The getter should stay unchanged.
There was a problem hiding this comment.
Their types have to be the same though. We can't have one being boolean | undefined and the other being boolean
There was a problem hiding this comment.
Hmmm, that sucks then.
OK, leave the setter as boolean then. If we need to, we can add a separate method like unsetNoEcho() later.
| MaxValue: this.maxValue, | ||
| MinLength: this.minLength, | ||
| MinValue: this.minValue, | ||
| NoEcho: this.noEcho, |
There was a problem hiding this comment.
Here, do use this._noEcho (you need the triple state boolean here).
skinny85
changed the title
comcalvi
force-pushed
the
mutable-parameters
branch
from
ffc95cd
to
5ec49dd
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes aws#9364 ---- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Closes #9364
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license